style(clustering/compat): style clean for checkers array #10858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liverpool8056 , I remove |
|
@chronolaw Yes, it's ok, |
hanshuebner
approved these changes
May 15, 2023
hanshuebner
suggested changes
May 15, 2023
I did not change the logic, so the original test cases should still work if they do have one. |
Do automated tests exist? How did you verify that the logic is unchanged? |
chronolaw
force-pushed
the
style/clustering_compat_checkers
branch
from
2e9c88a
to
b1ec93f
Compare
chronolaw
force-pushed
the
style/clustering_compat_checkers
branch
from
b1ec93f
to
37bac59
Compare
|
Rebase to #10759, more test cases to ensure it is correct. |
hanshuebner
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We should not put all un-related checking logic into one function,
this PR moves queue and valuts checking code to new functions.
Checklist